Repository navigation
wip Stable and unique Lambda and LambdaForm class names - #791
Draft
ThanHenderson wants to merge 1 commit into
Draft
ThanHenderson wants to merge 1 commit into
ThanHenderson wants to merge 1 commit into
Conversation
ThanHenderson
force-pushed
the
stable-lambda
branch
from
June 26, 2024 15:29
5770205 to
0fb8d0d
Compare
Contributor
Author
|
@babsingh @hangshao0 Could you guys take a look? My main point of concern here is "uniqueness" of the I am open to any other suggestions in how we should be generating the |
ThanHenderson
force-pushed
the
stable-lambda
branch
4 times, most recently
from
July 30, 2024 14:31
1221a9c to
aafbee2
Compare
This patch adds: - a unique ID to the generated Lambda and LambdaForm class names - MethodHandleNatives functions for checking if a Lambda or LambdaForm class is in the SCC based on the unique ID - early SCC-lookup for both Lambda and LambdaForm classes Signed-off-by: Nathan Henderson nathan.henderson@ibm.com
ThanHenderson
force-pushed
the
stable-lambda
branch
from
July 31, 2024 20:01
aafbee2 to
cc22819
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This WIP patch accompanies eclipse-openj9/openj9#19763 and replaces the index number in
Lambdaclass names with a stable hash-code, and adds a stable hash code to customizedLambdaFormclasses.The intent is to enable:
LambdaFormsto be stored in SCCLambdaandLambdaFormclassesLambdaswhen creating ROM classesSigned-off-by: Nathan Henderson nathan.henderson@ibm.com